Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tests, remove qunit only #1449

Merged
merged 2 commits into from
Nov 27, 2023
Merged

chore: fix tests, remove qunit only #1449

merged 2 commits into from
Nov 27, 2023

Conversation

dzianis-dashkevich
Copy link
Contributor

No description provided.

adrums86
adrums86 previously approved these changes Nov 27, 2023
wseymour15
wseymour15 previously approved these changes Nov 27, 2023
@adrums86 adrums86 dismissed stale reviews from wseymour15 and themself November 27, 2023 20:41

more changes need review

@adrums86 adrums86 requested a review from wseymour15 November 27, 2023 20:41
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f2a4de) 12.96% compared to head (8987a89) 86.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1449       +/-   ##
===========================================
+ Coverage   12.96%   86.16%   +73.20%     
===========================================
  Files          42       42               
  Lines       10613    10613               
  Branches     2445     2445               
===========================================
+ Hits         1376     9145     +7769     
+ Misses       9237     1468     -7769     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86
Copy link
Contributor

@dzianis-dashkevich Pushed the fixes for the pathway cloning tests.

@dzianis-dashkevich dzianis-dashkevich merged commit f294133 into main Nov 27, 2023
12 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the fix-tests branch November 27, 2023 21:04
dzianis-dashkevich added a commit that referenced this pull request Nov 30, 2023
* chore: fix tests, remove qunit only

* fix pathway cloning tests

---------

Co-authored-by: Dzianis Dashkevich <[email protected]>
Co-authored-by: Adam Waldron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants